Skip to content

Support chunked text processing via StreamSafe - #120

Merged
Manishearth merged 1 commit into
unicode-rs:masterfrom
maratik123:master
Oct 29, 2026
Merged

Manishearth merged 1 commit into
unicode-rs:masterfrom
maratik123:master

Conversation

@maratik123

Copy link
Copy Markdown
Contributor

Closes #119

@maratik123

Copy link
Copy Markdown
Contributor Author

I want to ask about .ok().expect(...).
Is it ok, or better to add #[derive(Debug)] to StreamSafe to make happy clippy (ok_expect) in future?
Because of that, test will fail on clippy immediatly if somebody will add this trait to StreamSafe.

Comment thread src/stream_safe.rs Resolved
@Manishearth

Copy link
Copy Markdown
Member

Derive debug is fine.

@Manishearth Manishearth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good!

Comment thread src/stream_safe.rs Resolved
Comment thread src/stream_safe.rs Resolved
Comment thread src/stream_safe.rs Resolved
@Manishearth
Manishearth merged commit 5a09b24 into unicode-rs:master Oct 29, 2026
13 checks passed
@Manishearth

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StreamSafe: carry the non-starter count across separate inputs (chunked streams)

2 participants